Skip to content

Conversation

@AdamTadeusz
Copy link
Contributor

Description

See issue for description

Linked Issues

@AdamTadeusz AdamTadeusz requested review from a team and nullsystem April 10, 2025 17:12
@AdamTadeusz AdamTadeusz marked this pull request as draft April 10, 2025 17:15
@AdamTadeusz
Copy link
Contributor Author

AdamTadeusz commented Apr 10, 2025

image

@nullsystem following this convention for water detail and shadow detail, we should set the label for shader detail to very high if r_lightmap_bicubic is set to 1, without then checking what mat_reducefillrate is set to. Wouldn't it be a good idea however to somehow indicate to the player that, if for example both r_lightmap_bicubic and mat_reducefillrate is set to 1 that even though the value is set to "Very High", that the graphical settings aren't at their highest?

@AdamTadeusz
Copy link
Contributor Author

I guess thats not really a big issue, updating a single setting should update all of these convars that could have a conflict to the values they are supposed to have

@AdamTadeusz AdamTadeusz marked this pull request as ready for review April 10, 2025 17:39
@nullsystem
Copy link
Collaborator

@AdamTadeusz I wouldn't bother with that specific case, it's basically an "odd" setting if it has it likely if the player somewhat tweaked both of those settings. Just let it do "very high".

@AdamTadeusz AdamTadeusz requested a review from nullsystem April 11, 2025 12:01
@nullsystem nullsystem requested a review from a team April 11, 2025 18:38
@AdamTadeusz AdamTadeusz merged commit 86b5604 into NeotokyoRebuild:master May 1, 2025
7 checks passed
@AdamTadeusz AdamTadeusz deleted the 195_shaderDetailVeryHighOption branch May 1, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing Shader detail option

3 participants