Ghost distribution is random across the map

[blaberry]

This is good in combo with the "spawns in the same place twice" plugin, but not sufficient, since "random over a large number of rounds" is not the same as "actually fair during a given game"

[blaberry]

Since ghost spawn bias is merged, is this also resolved? @Rainyan or is it just a case of "the ghost spawns twice in one location, but the spawn frequency is not evenly distributed across the different spawn locations"?

[Rainyan]

Since ghost spawn bias is merged, is this also resolved? @Rainyan or is it just a case of "the ghost spawns twice in one location, but the spawn frequency is not evenly distributed across the different spawn locations"?

@AdamTadeusz might know better since #1100 was his PR, but I can investigate later

[Rainyan]

I guess it depends on what we want the game design to be, ultimately. Surely not full native parity, because it's inherently broken.

But whether we want uniform distribution where streaks of the same-ish spawns are allowed, or weight it towards the less common spawns, I don't know. It is indeed a bit orthogonal to #1100's concept of playing sides of the same ghost.

One option would also be to ditch randomness altogether, and let the mapper decide the ghost sequence deterministically. But this is getting to bikeshedding territory.

[Rainyan]

As for the title of this issue in specific, I checked and the ghost spawns are indeed "correctly" (depending on one's opinion) distributed uniformly.

neo/src/game/shared/neo/neo_gamerules.cpp

Lines 1612 to 1613 in f5cf0e8

	// Randomly decide on a ghost spawn point we want this time
	const int desiredSpawn = RandomInt(1, numGhostSpawns);

Although that might not be what the issue description is looking for?