-
Notifications
You must be signed in to change notification settings - Fork 2
Add YouTube channel link #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add YouTube channel link to the header
brysondev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a media query for screen sizes <500px, maybe this plays nicer with mobile? @nullsystem mobile.webm |
|
I mean, looks good but why not just have it on the left to begin with? |
My thinking was that it looks kind of busy with all the links next to each other, and assuming the amount of social links is only gonna go up from here, it'll become hard to read. So we could have the Twatters and FaceMeTikTokBooks to the right, and the arguably more (dev) pertinent content to the left? Also, if we did choose to go for icons (this is just a mockup, the CSS is a bit misaligned): I think it would look better separated from the text links. Although as per YT brand resources docs, this would require us to fill a form to get permission to use the YT icon, so I opted for just a plain-text link for now. |



Add YouTube channel link to the header