Skip to content

Conversation

@Rainyan
Copy link
Contributor

@Rainyan Rainyan commented Feb 26, 2025

Add YouTube channel link to the header

Add YouTube channel link to the header
@Rainyan Rainyan changed the title Add YouTube link Add YouTube channel link Feb 26, 2025
Copy link
Contributor

@brysondev brysondev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@nullsystem
Copy link
Collaborator

nullsystem commented Feb 26, 2025

2025-02-26T185631_select
Looks like this on mobile view
Up to you if to left or keep right align it.

@Rainyan
Copy link
Contributor Author

Rainyan commented Feb 27, 2025

[image]
Looks like this on mobile view Up to you if to left or keep right align it.

I added a media query for screen sizes <500px, maybe this plays nicer with mobile? @nullsystem

mobile.webm

@Rainyan Rainyan requested a review from brysondev February 27, 2025 09:37
@brysondev
Copy link
Contributor

brysondev commented Feb 27, 2025

I mean, looks good but why not just have it on the left to begin with?

@Rainyan
Copy link
Contributor Author

Rainyan commented Feb 27, 2025

I mean, looks good but why not just have it on the left to begin with?

My thinking was that it looks kind of busy with all the links next to each other, and assuming the amount of social links is only gonna go up from here, it'll become hard to read. So we could have the Twatters and FaceMeTikTokBooks to the right, and the arguably more (dev) pertinent content to the left?

Also, if we did choose to go for icons (this is just a mockup, the CSS is a bit misaligned):

yt

I think it would look better separated from the text links. Although as per YT brand resources docs, this would require us to fill a form to get permission to use the YT icon, so I opted for just a plain-text link for now.

@Rainyan Rainyan merged commit 84c1dfd into NeotokyoRebuild:main Feb 28, 2025
@Rainyan Rainyan deleted the social branch February 28, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants