HPOS - Made the query for retrieving meta keys more performant (wooco…

…mmerce#46985) * Modified query for fetching meta key, making it more perfomant * added changelog * Improved query when include_private is true * Address review feedback * Address review feedback
Neosate · May 2, 2024 · 1ba1e91 · 1ba1e91
1 parent 6066c08
commit 1ba1e91
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/plugins/woocommerce/changelog/fix-add-cache-46806 b/plugins/woocommerce/changelog/fix-add-cache-46806
@@ -0,0 +1,4 @@
+Significance: patch
+Type: performance
+
+HPOS - Made the query for retrieving meta keys more performant
diff --git a/plugins/woocommerce/src/Internal/DataStores/CustomMetaDataStore.php b/plugins/woocommerce/src/Internal/DataStores/CustomMetaDataStore.php
@@ -250,7 +250,7 @@ public function get_meta_keys( $limit = 100, $order = 'ASC', $include_private =
 		$query = "SELECT DISTINCT meta_key FROM {$db_info['table']} ";
 
 		if ( ! $include_private ) {
-			$query .= $wpdb->prepare( 'WHERE meta_key != \'\' AND meta_key NOT LIKE %s ', $wpdb->esc_like( '_' ) . '%' );
+			$query .= $wpdb->prepare( "WHERE meta_key !='' AND meta_key NOT BETWEEN '_' AND '_z' AND meta_key NOT LIKE %s ", $wpdb->esc_like( '_' ) . '%' );
 		} else {
 			$query .= "WHERE meta_key != '' ";
 		}