feat(status): add hint #225
Conversation
|
I think this is a great idea, but could there also be a preference to disable it? |
|
@wongjiahau like @bronzehedwick said can you please add a config property? |
|
@TimUntersberger Sure! I'll try to get this done by today |
| @@ -104,6 +104,7 @@ local neogit = require("neogit") | |||
|
|
|||
| neogit.setup { | |||
| disable_signs = false, | |||
| disable_hint = false, | |||
There was a problem hiding this comment.
It matches the options, but wouldn't it be better to have them other way around? Maybe something like:
neogit.setup {
display = {
signs = true,
hint = true,
context_highlighting = true,
commit_confirmation = true,
},
}I know it's breaking change, but simplifies things in my opinion. What do you think @TimUntersberger? (most likely not part of that PR though)
There was a problem hiding this comment.
@gegoune That's actually more readable, but then these properties might not be easily searchable, which is part of the reason why I can find the relevant files quickly, say by searching for disable_signs.
There was a problem hiding this comment.
@gegoune I think grouping these together into a common subtable wouldn't be a bad idea, but I am not sure what to call it yet. Can you open a seperate issue for this?
|
LGTM! Thank you! |
|
@TimUntersberger Thanks! |
Preface
As a beginner I feel that it would be convenient to have the common keymap displayed all the time, otherwise I have to keep looking at the help file until I can memorize them.
Screenshots