fix: prevent --literal-pathspecs leaking into git hooks
#1893
+31
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Neogit currently adds
--literal-pathspecsto all git commands, which causes git to exportGIT_LITERAL_PATHSPECS=1to hooks. Hook managers such as hk can fail when runninggit stash.e.g. git error:
in this case commits abort with
Commit failedbefore the message editor opens.This change skips
--literal-pathspecsfor hook-triggering subcommands (commit/merge/rebase/checkout/push), preventing the env leak while keeping the flag for other commands.