Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to the Solve.* methods #1671

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Conversation

joschmitt
Copy link
Collaborator

@joschmitt joschmitt commented Feb 12, 2024

If Nemocas/AbstractAlgebra.jl#1604 is merged, the last commit will not be necessary any more.

@thofma
Copy link
Member

thofma commented Feb 12, 2024

I tagged AA 0.38.1, but the failing tests should be independent of this

@joschmitt
Copy link
Collaborator Author

Thank you. And, yes, they are.

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (ae0c3b1) 84.44% compared to head (6c71f1d) 84.38%.

Files Patch % Lines
src/HeckeMiscMatrix.jl 11.11% 8 Missing ⚠️
src/flint/nmod_mat.jl 60.00% 4 Missing ⚠️
src/flint/fmpz_mat.jl 91.30% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1671      +/-   ##
==========================================
- Coverage   84.44%   84.38%   -0.06%     
==========================================
  Files          93       93              
  Lines       37234    37234              
==========================================
- Hits        31443    31421      -22     
- Misses       5791     5813      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joschmitt joschmitt closed this Feb 12, 2024
@joschmitt joschmitt reopened this Feb 12, 2024
@thofma thofma merged commit 2098cf8 into Nemocas:master Feb 12, 2024
25 of 41 checks passed
@joschmitt joschmitt deleted the js/solvesolve branch February 13, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants