Skip to content

Conversation

@lgoettgens
Copy link
Member

Resolves #2140.

We used to use the internal function Base.process_backtrace() that was changed in JuliaLang/julia#55841. This PR updates the code to instead use Base.stacktrace (which is public aka guaranteed to stay), but we now need to take care of kwcall ourselves.

@codecov
Copy link

codecov bot commented Aug 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.96%. Comparing base (e3a4248) to head (073c77c).
⚠️ Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2141      +/-   ##
==========================================
- Coverage   87.97%   87.96%   -0.01%     
==========================================
  Files         126      126              
  Lines       31659    31671      +12     
==========================================
+ Hits        27851    27860       +9     
- Misses       3808     3811       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lgoettgens
Copy link
Member Author

Since CI is happy with this change, I am continuing to merge this to make CI green again. But please give this a review nonetheless when you are back from vacation. We can adapt things afterwards anyway.

@lgoettgens lgoettgens merged commit 2854c05 into Nemocas:master Aug 7, 2025
21 checks passed
@lgoettgens lgoettgens deleted the lg/nightly-banner branch August 7, 2025 09:04
fieker pushed a commit that referenced this pull request Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

should_show_banner broken in Julia nightly

1 participant