Equal FPModules must have the same hash value
#2139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a `==` method for two `FPModule`s that compares w.r.t. equality as sets. The default `hash` method compares the `objectid`s. In order to satisfy the general rule that `isequal(x,y)` implies `hash(x) == hash(y)`, we need a special `hash` method.
ThomasBreuer
added
bugfix
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2139 +/- ##
=======================================
Coverage 87.97% 87.97%
=======================================
Files 126 126
Lines 31671 31671
=======================================
Hits 27861 27861
Misses 3810 3810 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
The failure in Julia nightly seems to be caused by the changes from JuliaLang/julia/pull/55841. |
This was referenced Aug 6, 2025
lgoettgens
approved these changes
Aug 6, 2025
Merged
fieker
pushed a commit
that referenced
this pull request
Sep 5, 2025
There is a `==` method for two `FPModule`s that compares w.r.t. equality as sets. The default `hash` method compares the `objectid`s. In order to satisfy the general rule that `isequal(x,y)` implies `hash(x) == hash(y)`, we need a special `hash` method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a
==method for twoFPModules that compares w.r.t. equality as sets.The default
hashmethod compares theobjectids.In order to satisfy the general rule that
isequal(x, y)implieshash(x) == hash(y), we need a specialhashmethod.