Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FreeModule -> free_module; VectorSpace -> vector_space #1626

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

fingolfin
Copy link
Member

No description provided.

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.94%. Comparing base (fc5b3c9) to head (fd582c2).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1626      +/-   ##
==========================================
+ Coverage   86.93%   86.94%   +0.01%     
==========================================
  Files         114      114              
  Lines       29700    29696       -4     
==========================================
  Hits        25819    25819              
+ Misses       3881     3877       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lgoettgens
Copy link
Collaborator

We should be consistent between #1625 and this. One introduces aliases and one deprecations.

@fingolfin
Copy link
Member Author

I would argue both should use @alias then, otherwise both are breaking because Oscar.jl uses UniversalPolynomialRing and FreeModule and we might get deprecation warnings which will be treated as errors there?

In the past this was always the policy with renamings: first we make aliases then adapt all places to use the new names, and only when everything is renamed do we even consider removing aliases (if at all).

@lgoettgens lgoettgens merged commit 4546165 into master Feb 28, 2024
30 checks passed
@lgoettgens lgoettgens deleted the mh/FreeModule branch February 28, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants