Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use is_one instead of == 1 #1591

Merged
merged 2 commits into from
Feb 2, 2024
Merged

fix: use is_one instead of == 1 #1591

merged 2 commits into from
Feb 2, 2024

Conversation

thofma
Copy link
Member

@thofma thofma commented Feb 2, 2024

(Found by Yue Ren.)

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (14b8c2b) 87.17% compared to head (aef7308) 87.17%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1591   +/-   ##
=======================================
  Coverage   87.17%   87.17%           
=======================================
  Files         115      115           
  Lines       29565    29565           
=======================================
  Hits        25773    25773           
  Misses       3792     3792           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lgoettgens lgoettgens closed this Feb 2, 2024
@lgoettgens lgoettgens reopened this Feb 2, 2024
@thofma thofma merged commit c8b22bf into master Feb 2, 2024
15 of 25 checks passed
@thofma thofma deleted the th/fixfix branch February 2, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants