-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fix generalized indexing #1585
Conversation
thofma
commented
Jan 29, 2024
- make A[i::Int, js::Array] return a Vector and support views
Split off from #1565, since it is easier this way. |
This is breaking, but I want to add it in this 0.37.* round. Or maybe not. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1585 +/- ##
==========================================
- Coverage 87.17% 86.93% -0.24%
==========================================
Files 115 115
Lines 29565 30075 +510
==========================================
+ Hits 25773 26147 +374
- Misses 3792 3928 +136 ☔ View full report in Codecov by Sentry. |
If this is breaking, we cannot include it in 0.37.2. Instead, this has to wait for 0.38.0 |
Yeah, 0.38.0 it is |
- make A[i::Int, js::Array] return a Vector and support views
- make A[i::Int, js::Array] return a Vector and support views