Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: minor improvements for residue maps #1563

Merged
merged 1 commit into from
Jan 23, 2024
Merged

feat: minor improvements for residue maps #1563

merged 1 commit into from
Jan 23, 2024

Conversation

thofma
Copy link
Member

@thofma thofma commented Jan 23, 2024

  • Some types in Nemo only do lift properly
  • Sanity check for image function

- Some types in Nemo only do lift properly
- Sanity check for image function
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1f95e91) 87.13% compared to head (eebaaa0) 87.12%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1563      +/-   ##
==========================================
- Coverage   87.13%   87.12%   -0.01%     
==========================================
  Files         115      115              
  Lines       29536    29537       +1     
==========================================
- Hits        25736    25735       -1     
- Misses       3800     3802       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thofma thofma merged commit 3aa8d1f into master Jan 23, 2024
14 of 15 checks passed
@thofma thofma deleted the th/rres branch January 23, 2024 22:22
ooinaruhugh pushed a commit to ooinaruhugh/AbstractAlgebra.jl that referenced this pull request Feb 15, 2024
- Some types in Nemo only do lift properly
- Sanity check for image function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant