Add missing _unwrap call in Dedent handler #1447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also clarify write_indent code, it is always called on an IOCustom instance
|
I have no idea how this code works and would thus leave the review to @thofma. |
Codecov Report
@@ Coverage Diff @@
## master #1447 +/- ##
==========================================
- Coverage 84.60% 84.30% -0.30%
==========================================
Files 109 110 +1
Lines 29370 29613 +243
==========================================
+ Hits 24848 24965 +117
- Misses 4522 4648 +126
... and 10 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Looks good. Are the doctest failure on Oscar master expected? Just checking |
|
Ignore my last comment. I saw the Oscar issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also clarify write_indent code, it is always called on an IOCustom instance