Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generic rising_factorial and rising_factorial2 #1445

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

fingolfin
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #1445 (ea0e065) into master (7ba6303) will increase coverage by 0.00%.
Report is 2 commits behind head on master.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1445   +/-   ##
=======================================
  Coverage   84.60%   84.60%           
=======================================
  Files         109      109           
  Lines       29361    29370    +9     
=======================================
+ Hits        24841    24849    +8     
- Misses       4520     4521    +1     
Files Changed Coverage Δ
src/AbstractAlgebra.jl 56.25% <ø> (ø)
src/generic/Misc/Rings.jl 36.00% <100.00%> (+36.00%) ⬆️

... and 9 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fingolfin
Copy link
Member Author

Note that Nemo already has specialized methods for rising_factorial and rising_factorial2 so this may be breaking for that reason (i.e., import/export shuffling).

But the implementations there are only for numbers; but this is also useful for e.g. polynomials. And rising_factorial2 in Nemo is only available for arb/RealFieldElem/acb/ComplexFieldElem, but not for e.g. integers.

@thofma
Copy link
Member

thofma commented Sep 19, 2023

Looks good, but doctests are failing.

@fingolfin
Copy link
Member Author

Fixed now

@fingolfin fingolfin enabled auto-merge (squash) September 19, 2023 08:34
@fingolfin fingolfin merged commit f23ced5 into master Sep 19, 2023
13 of 15 checks passed
@fingolfin fingolfin deleted the mh/rising_factorial branch September 19, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants