fix: make dot work again

Nemocas · Feb 2, 2024 · 4c7deac · 4c7deac
1 parent c8b22bf
commit 4c7deac
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 0 deletions.
diff --git a/src/AbstractAlgebra.jl b/src/AbstractAlgebra.jl
@@ -29,6 +29,7 @@ const import_exclude = [:import_exclude, :QQ, :ZZ,
 # They should not be imported/exported anywhere else.
 
 import LinearAlgebra: det
+import LinearAlgebra: dot
 import LinearAlgebra: hessenberg
 import LinearAlgebra: ishermitian
 import LinearAlgebra: issymmetric

diff --git a/src/Rings.jl b/src/Rings.jl
@@ -174,3 +174,15 @@ is_finite(F::FinField) = true
 is_finite(F::Field) = characteristic(F) != 0 && throw(NotImplementedError(:is_finite, F))
 
 characteristic(F::NumField) = 0
+
+################################################################################
+#
+#   Dot
+#
+################################################################################
+
+dot(x::RingElem, y::RingElem) = x * y
+
+dot(x::RingElem, y::Union{Integer, Rational, AbstractFloat}) = x * y
+
+dot(x::Union{Integer, Rational, AbstractFloat}, y::RingElem) = x * y
diff --git a/test/Rings-test.jl b/test/Rings-test.jl
@@ -67,3 +67,12 @@ end
   @test is_finite(GF(2))
   @test !is_finite(QQ)
 end
+
+@testset "dot" begin
+  Qx, x  = QQ["x"]
+  @test dot([x, x^2], [1, 1]) == x + x^2
+  @test dot([x, x^2], Rational{BigInt}[1, 1]) == x + x^2
+  @test dot([1, 1], [x, x^2]) == x + x^2
+  @test dot(Rational{BigInt}[1, 1], [x, x^2]) == x + x^2
+  @test dot([x], [x^2]) == x^3
+end