Use webpack hooks #357
Merged
Use webpack hooks #357
+103
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Unfortunately this isn't an option. It should support versions 2-4. That's what v5 will be supporting. |
Contributor
Author
|
No problem. I’ll update the PR to support both APIs. |
Owner
|
Okay, sounds good, thanks! |
In webpack 4, `Tapable#apply` and `Tapable#plugin` raise a **deprecation notice**. - `Tapable#apply(plugin)` must be replaced by a call to `plugin.apply` - `Tapable#plugin(hook, fn)` must be replaced by a call to `hook.tap` (or `hook.tapAsync`) **Note:** This is breaking change because it drops webpack < 4 compatibility.
ooflorent
force-pushed
the
webpack_hooks
branch
from
e68a8bd to
daddd83
Compare
Contributor
Author
|
I don't understand the CI failure. Tests are fine when ran locally. |
Owner
It's travis issue, it's just too slow to handle browser tests and they fail with timeout. |
Owner
|
Anyway, I guess if tests pass, then everything works 🙃 Merging. Thank you for the PR and follow up updates regarding previous versions support! 👏🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In webpack 4,
Tapable#applyandTapable#pluginraise a deprecation notice.Tapable#apply(plugin)must be replaced by a call toplugin.applyTapable#plugin(hook, fn)must be replaced by a call tohook.tap(orhook.tapAsync)Note: This is breaking change because it drops webpack < 4 compatibility.