Skip to content

SPA.md seems to be outdated, and contradicts app-shell.md #335

@JobLeonard

Description

@JobLeonard

We should also specify the ServiceWorker.navigateFallbackURL, which instructs the service worker to redirect any non-cached navigation request to the specified route.

https://github.com/NekR/offline-plugin/blob/master/docs/examples/SPA.md

Previously, to achieve the same effect, ServiceWorker.navigateFallbackURL and AppCache.FALLBACK option had to be used. ServiceWorker.navigateFallbackURL is now deprecated and shouldn't be used at all. Instead, appShell should be used.

https://github.com/NekR/offline-plugin/blob/master/docs/app-shell.md

I'm not entirely sure what the correct documentation would be, but given that the SPA one is older I assume it's the outdated one. Since it is the first and only linked example from the README.md, this can lead people astray.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions