Adds simply fullscreen mode #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
quardbreak
commented
Mar 13, 2020
quardbreak
commented
| /datum/client_preference/fullscreen_mode | ||
| description = "Toggle Fullscreen Mode" | ||
| key = "TOGGLE_FULLSCREEN" | ||
| options = list(GLOB.PREF_NO, GLOB.PREF_YES) |
There was a problem hiding this comment.
Any particular reason for switching Yes/No around? It makes it inconsistent with other settings using the same options.
Should instead be able to instead do default_value = GLOB.PREF_NO
| /datum/client_preference/fullscreen_mode | ||
| description = "Fullscreen Mode" | ||
| key = "FULLSCREEN" | ||
| options = list(GLOB.PREF_YES, GLOB.PREF_NO) |
There was a problem hiding this comment.
This is the same as the default options value
quardbreak
force-pushed
the
fullscreen
branch
2 times, most recently
from
0078c98 to
a4c68e9
Compare
fix format
MistakeNot4892
approved these changes
Mar 13, 2020
MistakeNot4892
pushed a commit
to MistakeNot4892/Nebula
that referenced
this pull request
Dec 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.