Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for nebula 0.8.11 #586

Merged
merged 14 commits into from
Oct 19, 2022
Merged

Conversation

starfi5h
Copy link
Collaborator

@starfi5h starfi5h commented Oct 7, 2022

Add:

Bugfixes:

  • fix index out-of-range error for logistic bots
IndexOutOfRangeException: Index was outside the bounds of the array.
NebulaWorld.Logistics.CourierManager.GameTick (System.Int64 time);(IL_0473)
NebulaPatcher.Patches.Dynamic.GameData_Patch.GameTick_Postfix (GameData __instance, System.Int64 time);(IL_0012)
NullReferenceException: Object reference not set to an instance of an object
NebulaNetwork.PacketProcessors.Logistics.DispenserCourierProcessor.ProcessPacket (NebulaModel.Packets.Logistics.DispenserCourierPacket packet, NebulaModel.Networking.NebulaConnection conn);(IL_003B)
  • fix error with GS2 when client click on planet/star on starmap to view detail
NullReferenceException: Object reference not set to an instance of an object
NebulaModel.Packets.Planet.PlanetDetailResponse..ctor (System.Int32 planetId, VeinGroup[]& veinGroups, System.Single landPercent);(IL_000D)
NebulaNetwork.PacketProcessors.Planet.PlanetDetailRequestProcessor.ProcessPacket (NebulaModel.Packets.Planet.PlanetDetailRequest packet, NebulaModel.Networking.NebulaConnection conn);(IL_0074)
  • fix PlayerManager.SendPacketToOtherPlayers<T>(T packet, INebulaConnection exclude) bug which cause research queue pause/resume doesn't sync correctly for another client
  • changes to make nebula run on XGP version

@starfi5h starfi5h marked this pull request as ready for review October 7, 2022 13:38
PhantomGamers and others added 4 commits October 15, 2022 02:54
gamepass version uses a different exe name, and the dependency isnt really required for functionality
System.IO is needed in release now as well
@starfi5h starfi5h merged commit ee63b66 into NebulaModTeam:master Oct 19, 2022
@starfi5h starfi5h deleted the pr-bugfix0.8.11 branch November 5, 2022 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants