Skip to content

Conversation

@ashutoshvarma
Copy link

Fix #844

Note: -

Instead of adding a new require(_admin != address(0) (and copying the comment to describe why) I used existing verifyAdminAddress() to reduce redundancy but the existing method name and require error message might not be appropriate. Also, the fact that newAdmin != admin will hit first rather than zero address check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AdminControlled: don't allow zero-address initialization

1 participant