Skip to content

Conversation

Tijes123
Copy link

This adds an option to automatically open a search result if it is the only result.

This feature makes it possible to quickly select search results, however it does make searching the web impossible, because KISS will have probably opened a search result before you finished writing your prompt. It also increases the chances of accidentally opening the wrong app. That is why this feature is disabled by default.

I am not entirely sure if "Search settings -> Misc." is the best place to put this option, it could also be put under the advanced settings.

Below is a video showing the feature in action.
https://github.com/user-attachments/assets/c3f286c8-1699-434f-ab78-cc7defa92cbb

@marunjar
Copy link
Collaborator

Still not sure what to do with this feature.

As you already found out it will break single search providers completely which is defined by default. If there are more search providers defined, it will never work as intended.

Also the first entry in results can be launched already by just pressing enter/search in keyboard if you're fine with result of your search.

Please check #555 #572 #1751 #2379 first for further discussions too.

@Tijes123
Copy link
Author

Thanks for looking into my PR. I really should have read those Issues, I did not realize that this had already been discussed.

The reason I like this feature is that I have grown used to it while using CCLauncher. I personally find giving up the web search functionality for avoiding the extra click a good compromise and these issues show that I am not the only one.

I can see that this goes against the indented workflow of the KISS launcher, so I understand that you would not want to include such a feature. Especially because my implementation is a bit too naive.

@ferrisx
Copy link

ferrisx commented Aug 30, 2025

ferrisx improve these changes verified

@marunjar
Copy link
Collaborator

The reason I like this feature is that I have grown used to it while using CCLauncher. I personally find giving up the web search functionality for avoiding the extra click a good compromise and these issues show that I am not the only one.

I checked cclauncher now and it seems to be a lot simpler than KISS.

I can see that this goes against the indented workflow of the KISS launcher, so I understand that you would not want to include such a feature. Especially because my implementation is a bit too naive.

If feature is disabled by default this is fine.
IMO behaviour should be clear too when this is enabled and I'm not convinced of user experience as it is now.

It may work if there were only apps (and maybe settings and shortcuts) taken into account, but currently there can be lots of other search results which may lead to unexpected behaviour:

  • calculator: triggered action copies result to clipboard
  • web search:
    • single search provider: search will be done as soon as nothing else is found
    • multiple search providers: nothing will happen because there is always more than one result
  • search for any supported uri, eg. tel://callme: action will trigger supported app, e.g. phone, as soon as uri is recognized as valid one
  • search for any phone number: result is shown where triggered action will call that number directly
  • contacts: triggered action may open contact or even call contact directly

What will others expect when this is enabled?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants