Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding C bindings for FilesystemModuleResolver #44

Merged
merged 6 commits into from
Sep 18, 2024

Conversation

Kbz-8
Copy link
Contributor

@Kbz-8 Kbz-8 commented Sep 16, 2024

Add bindings:

  • FilesystemModuleResolver
    • nzslFsModuleResolverCreate
    • nzslFsModuleResolverDestroy
    • nzslFsModuleResolverGetLastError
    • nzslFsModuleResolverRegisterModule
    • nzslFsModuleResolverRegisterModuleFromFile
    • nzslFsModuleResolverRegisterModuleFromSource
    • nzslFsModuleResolverRegisterModuleDirectory

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 39 lines in your changes missing coverage. Please review.

Project coverage is 77.03%. Comparing base (ac9ac60) to head (708247e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/CNZSL/FilesystemModuleResolver.cpp 0.00% 37 Missing ⚠️
src/CNZSL/WriterStates.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
- Coverage   77.17%   77.03%   -0.15%     
==========================================
  Files         149      150       +1     
  Lines       20362    20401      +39     
  Branches     6231     6077     -154     
==========================================
  Hits        15715    15715              
- Misses       4579     4624      +45     
+ Partials       68       62       -6     
Files with missing lines Coverage Δ
src/CNZSL/WriterStates.cpp 0.00% <0.00%> (ø)
src/CNZSL/FilesystemModuleResolver.cpp 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac9ac60...708247e. Read the comment docs.

@SirLynix
Copy link
Contributor

Thanks!

@SirLynix SirLynix merged commit 4e71c2b into NazaraEngine:main Sep 18, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants