Implement FLAC file support #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice work! I merged your pull request. |
|
If I find any issues I will make sure to fix them :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been looking for a plugin to play custom music without resource packs in my server for a very long time but I finally found this one and I like it a lot so I am doing my part and implementing FLAC file support as it is the format I use the most for storing my music collection.
FLAC files have some advantages over WAVE as they are smaller whilst still being bit-perfect. Hence the name Free Lossless Audio Codec.
I know that Simple Voice Chat uses a lossy codec to transmit the audio to players however it is convinient not having to transcode my songs to a different format whenever I want to create a custom disc.
Lastly I would like to point out that I am not a professional Java developer and it is not my first language so if I made any mistakes or did not follow the best practices please let me know, closes #29.