Skip to content

Feat/reverse add benchmark #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 20, 2025

Conversation

umsungjun
Copy link
Contributor

  • add benchmark for reverse function
  • add JSDoc to reverse function
스크린샷 2025-05-16 오후 4 28 34

@umsungjun umsungjun requested a review from a team as a code owner May 16, 2025 07:30
Copy link
Contributor

✅ All utility modules are properly registered in index.ts and package.json exports!

Copy link
Contributor

Benchmark Results

Method Test Performance Comparison hidash ops/sec lodash@4.17.21 ops/sec
reverse src/reverse.bench.ts > reverse performance hidash is 1.92x faster 1121.21 🏆 583.36

Note: Higher operations per second (ops/sec) numbers are better. Each test compares hidash vs lodash implementation.

⚠️ indicates where hidash is slower than lodash.

🏆 indicates the faster implementation.

View Full Benchmark Data
{
  "files": [
    {
      "filepath": "/home/runner/work/hidash/hidash/src/reverse.bench.ts",
      "groups": [
        {
          "fullName": "src/reverse.bench.ts > reverse performance",
          "benchmarks": [
            {
              "id": "1293779284_0_0",
              "name": "hidash",
              "rank": 1,
              "rme": 0.21785866618777688,
              "samples": [],
              "totalTime": 500.3502759999989,
              "min": 0.8774610000000393,
              "max": 1.1877110000000357,
              "hz": 1121.2145309179389,
              "period": 0.8918899750445614,
              "mean": 0.8918899750445614,
              "variance": 0.0005513443953959119,
              "sd": 0.023480723911240724,
              "sem": 0.000991356940558458,
              "df": 560,
              "critical": 1.96,
              "moe": 0.0019430596034945777,
              "p75": 0.8907350000000065,
              "p99": 1.017041000000063,
              "p995": 1.0560839999999985,
              "p999": 1.1877110000000357,
              "sampleCount": 561,
              "median": 0.8874490000000037
            },
            {
              "id": "1293779284_0_1",
              "name": "lodash",
              "rank": 2,
              "rme": 0.23694041018547346,
              "samples": [],
              "totalTime": 500.54726299999936,
              "min": 1.6841589999999087,
              "max": 2.0068430000000035,
              "hz": 583.3614956755849,
              "period": 1.7142029554794498,
              "mean": 1.7142029554794498,
              "variance": 0.0012539304816919282,
              "sd": 0.03541088083756076,
              "sem": 0.0020722650582267943,
              "df": 291,
              "critical": 1.96,
              "moe": 0.004061639514124517,
              "p75": 1.7154570000000149,
              "p99": 1.9522999999999229,
              "p995": 1.9568189999999959,
              "p999": 2.0068430000000035,
              "sampleCount": 292,
              "median": 1.7063355000000797
            }
          ]
        }
      ]
    }
  ]
}

Last updated by GitHub Actions

Copy link
Contributor

@yujeong-jeon yujeong-jeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~!

@yceffort-naver yceffort-naver merged commit 5d50834 into NaverPayDev:main May 20, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants