Skip to content

feat: add benchmark for last #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2025

Conversation

umsungjun
Copy link
Contributor

Added last.bench.ts for performance comparison with Lodash.
Removed duplicated test cases from last.test.ts.

스크린샷 2025-05-14 오후 8 20 16

스크린샷 2025-05-14 오후 8 20 34

@umsungjun umsungjun requested a review from a team as a code owner May 14, 2025 11:28
Copy link
Contributor

✅ All utility modules are properly registered in index.ts and package.json exports!

Copy link
Contributor

Benchmark Results

Method Test Performance Comparison hidash ops/sec lodash@4.17.21 ops/sec
last src/last.bench.ts > last performance hidash is 4.52x faster 2273.15 🏆 503.01

Note: Higher operations per second (ops/sec) numbers are better. Each test compares hidash vs lodash implementation.

⚠️ indicates where hidash is slower than lodash.

🏆 indicates the faster implementation.

View Full Benchmark Data
{
  "files": [
    {
      "filepath": "/home/runner/work/hidash/hidash/src/last.bench.ts",
      "groups": [
        {
          "fullName": "src/last.bench.ts > last performance",
          "benchmarks": [
            {
              "id": "219956842_0_0",
              "name": "hidash",
              "rank": 1,
              "rme": 0.8468204792761417,
              "samples": [],
              "totalTime": 500.18623299999837,
              "min": 0.4027219999999261,
              "max": 1.0208169999999654,
              "hz": 2273.1533276726623,
              "period": 0.439917531222514,
              "mean": 0.439917531222514,
              "variance": 0.004107462106791707,
              "sd": 0.06408948514999716,
              "sem": 0.0019006692583256447,
              "df": 1136,
              "critical": 1.96,
              "moe": 0.0037253117463182635,
              "p75": 0.4361050000000546,
              "p99": 0.8358410000000163,
              "p995": 0.8669090000000779,
              "p999": 0.9831560000000081,
              "sampleCount": 1137,
              "median": 0.428278999999975
            },
            {
              "id": "219956842_0_1",
              "name": "lodash",
              "rank": 2,
              "rme": 0.5110840071196997,
              "samples": [],
              "totalTime": 500.980728999999,
              "min": 1.9327990000000455,
              "max": 3.1327890000000025,
              "hz": 503.01336042009814,
              "period": 1.9880187658730117,
              "mean": 1.9880187658730117,
              "variance": 0.006771953068156103,
              "sd": 0.08229187729148062,
              "sem": 0.005183901005569077,
              "df": 251,
              "critical": 1.96,
              "moe": 0.01016044597091539,
              "p75": 1.989955000000009,
              "p99": 2.251323999999954,
              "p995": 2.320022000000108,
              "p999": 3.1327890000000025,
              "sampleCount": 252,
              "median": 1.977292000000034
            }
          ]
        }
      ]
    }
  ]
}

Last updated by GitHub Actions

Copy link
Contributor

@yujeong-jeon yujeong-jeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised by your fast pace of work 😮 👍

Thank you for contributing today as well!

@yceffort-naver yceffort-naver merged commit 08d0f93 into NaverPayDev:main May 14, 2025
6 of 7 checks passed
@umsungjun
Copy link
Contributor Author

First of all, I'd like to sincerely thank the NaverPay team for developing the hidash open source library.
I truly appreciate the kind and encouraging words you leave every time I submit a PR they always motivate me.

Thanks to your support, I've been learning a lot. I’ll continue contributing consistently and do my best to be helpful to the hidash project. Thank you again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants