Skip to content

Conversation

m-radzikowski
Copy link
Contributor

Purpose / Goal

Fixes #564

The jPath in updateTag() callback for self-closing tags contained a trailing slash (like: root.a/) which was not intended and could lead to errors if you implemented logic based on the jPath and did not take that into account.

I've added removing trailing slash from jPath in the same place where it's removed from tagName.

Type

Please mention the type of PR

  • [x]Bug Fix
  • [ ]Refactoring / Technology upgrade
  • [ ]New Feature

@coveralls
Copy link

Coverage Status

coverage: 98.24% (+0.004%) from 98.236% when pulling ec4862c on m-radzikowski:issue-564 into 643816d on NaturalIntelligence:master.

@amitguptagwl amitguptagwl merged commit 2f2f787 into NaturalIntelligence:master Jun 27, 2023
@m-radzikowski
Copy link
Contributor Author

Hey @amitguptagwl, any chance you could release a new version with this fix?

@amitguptagwl
Copy link
Member

Done. Sorry for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

jPath for self-closing XML tag includes slash

3 participants