Merge pull request mozilla-services#467 from ossreleasefeed/visual-in…

…dicator-startup-crashes-732067 Using new column added to tcbs instead of sig summary service prevents the 100 queries horror
NatronGitHub · Mar 28, 2012 · 69bf340 · 69bf340
2 parents 1ab28e1 + 30571da
commit 69bf340
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 36 deletions.
diff --git a/webapp-php/application/config/topcrashers.php-dist b/webapp-php/application/config/topcrashers.php-dist
@@ -4,15 +4,4 @@
  * The number of signatures to display.
  */
 $config['numberofsignatures'] = 20;
-
-/**
- * The category value against which to check for startup crashes
- */
-$config['total_uptime_condition'] = "< 1 min";
-
-/**
- * The percentage of crashes that needs to be surpased to be marked 
- * a startup crasher.
- */
- $config['percentage_uptime_condition'] = "50";
 ?>
diff --git a/webapp-php/application/controllers/topcrasher.php b/webapp-php/application/controllers/topcrasher.php
@@ -317,7 +317,9 @@ public function byversion($product=null, $version=null, $duration=null, $crash_t
                     $top_crasher->{'display_percent'} = number_format($top_crasher->percentOfTotal * 100, 2) . "%";
                     $top_crasher->{'display_previous_percent'} = number_format($top_crasher->previousPercentOfTotal * 100, 2) . "%";
                     $top_crasher->{'display_change_percent'} = number_format($top_crasher->changeInPercentOfTotal * 100, 2) . "%";
-                    $top_crasher->{'startup_crash'} = $this->topcrashers_model->isStartupCrasher($top_crasher->signature, $resp->start_date, $params->end_date);
+                    if(isset($top_crasher->startup_percent) && !empty($top_crasher->startup_percent)) {
+                        $top_crasher->{'startup_crash'} = (round($top_crasher->startup_percent) > 50);
+                    }
 
                     array_push($signatures, $top_crasher->signature);
 
@@ -410,7 +412,9 @@ public function byos($product=null, $version=null, $os=null, $duration=null, $cr
                     $top_crasher->{'display_percent'} = number_format($top_crasher->percentOfTotal * 100, 2) . "%";
                     $top_crasher->{'display_previous_percent'} = number_format($top_crasher->previousPercentOfTotal * 100, 2) . "%";
                     $top_crasher->{'display_change_percent'} = number_format($top_crasher->changeInPercentOfTotal * 100, 2) . "%";
-                    $top_crasher->{'startup_crash'} = $this->topcrashers_model->isStartupCrasher($top_crasher->signature, $resp->start_date, $params->end_date);
+                    if(isset($top_crasher->startup_percent) && !empty($top_crasher->startup_percent)) {
+                        $top_crasher->{'startup_crash'} = (round($top_crasher->startup_percent) > 50);
+                    }
 
                     array_push($signatures, $top_crasher->signature);
                     $top_crasher->{'correlation_os'} = Correlation::correlationOsName($top_crasher->win_count, $top_crasher->mac_count, $top_crasher->linux_count);

diff --git a/webapp-php/application/models/topcrashers.php b/webapp-php/application/models/topcrashers.php
@@ -80,29 +80,6 @@ public function buildURI($params, $apiEntry)
 
         return implode($separator, $apiData);
     }
-
-    /**
-     * Determined whether the current signature can be labeled as a 
-     * startup crasher based on the total percentage for uptime < 1min
-     * 
-     * @param string the signature
-     * @param date the start date
-     * @param date the end date
-     * @return bool
-     */
-    public function isStartupCrasher($signature, $start_date, $end_date) {
-        $summary_model = new Signature_Summary_Model();
-        $uptime = $summary_model->getSummary('uptime', $signature, $start_date, $end_date);
-        foreach($uptime as $up) {
-            $total_uptime = $up->category;
-            $percentage = round($up->percentage * 100);
-
-            if(($total_uptime === Kohana::config('topcrashers.total_uptime_condition')) && ($percentage > Kohana::config('topcrashers.percentage_uptime_condition'))) {
-                return TRUE;
-            }
-        }
-        return FALSE;
-    }
 
     /**
      * Fetch the top crashers data via a web service call.