Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(geolocation): remove permissions from plugin #193

Merged
merged 4 commits into from
Oct 29, 2021
Merged

feat(geolocation): remove permissions from plugin #193

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7311adf
bump plugin version
bradmartin Oct 29, 2021
2a357b7
update readme
bradmartin Oct 29, 2021
ed35912
remove manifest from geolocation plugin for permissions
bradmartin Oct 29, 2021
4c71b16
add breaking change note to README
bradmartin Oct 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
add breaking change note to README
  • Loading branch information
@bradmartin
bradmartin committed Oct 29, 2021
commit 4c71b16e207d09803716ff6679a9ea4e7fb661a4
5 changes: 5 additions & 0 deletions packages/geolocation/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@ Geolocation plugin to use for getting current location, monitor movement, etc.
ns plugin add @nativescript/geolocation
```

> **Important Breaking Change**
> Version 8.0.0 of the plugin remove the Android permissions from the plugin.
> The developer is now responsible for adding the permission(s) that their app needs.
> More info below.

## Permissions Android

In order to use geolocation on Android, you'll need to add the following permission(s) to your app's `AndroidManifest.xml` inside the `App_Resources/Android/src/main` dir:
Expand Down