-
-
Notifications
You must be signed in to change notification settings - Fork 15
Nx 20 support #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nx 20 support #79
Conversation
pawel-twardziak
commented
Oct 13, 2024
- migrate workspace to NX 20
- align the generators code to the NX API: library and application
- clean up the generators code: library and application (much useless code)
Thank you for kicking this off! |
hi @NathanWalker I need this migration for my green field project. Almost done, tested and all work. Still some chores to get done. |
3934a5c
to
a9b6abb
Compare
@NathanWalker I will be working on this for the next week - so should be done soon :) |
ok excellent @pawel-twardziak just ping when ready and we'll merge this into the other pending PR which has ton of executor standardization improvements before releasing v20. |
Hi @NathanWalker I see there has beed done a huge job out there #57 Btw I have got sick a bit. Getting better and better |
If you want to try the merge, you could try merging his into yours or vice versa - ideally we want to merge both your work here and that one. |
I don't like merging other people's work with anything but the main :) Simply out of respect for someone else's work. |
And I am activly migrating https://github.com/nxext/nx-extensions (it is done, now fixing period) to NX20 too, so I work on two fronts 😆 |
Agreed, just make this ready for review when ready and we'll merge this first then. |
Thank you @NathanWalker 👍 I am sluggish as being sick but I am speeding up! 😺 |
Hi @NathanWalker I will be continuing on it this Sunday (unfortunately tomorrow I cannot). Expect my PR ready by 4pm. I was delayed due to illness. |
@NathanWalker ready to CR. In general, for some reason, fixing package dep version while UPDATE: I've just activated fixing package dep versions while |
@NathanWalker are you there? :) |
We’ll check that out and get this merged today |