Skip to content

Nx 20 support #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Oct 22, 2024
Merged

Conversation

pawel-twardziak
Copy link
Contributor

  • migrate workspace to NX 20
  • align the generators code to the NX API: library and application
  • clean up the generators code: library and application (much useless code)

@pawel-twardziak pawel-twardziak marked this pull request as draft October 13, 2024 04:14
@NathanWalker
Copy link
Contributor

Thank you for kicking this off!

@pawel-twardziak
Copy link
Contributor Author

hi @NathanWalker I need this migration for my green field project. Almost done, tested and all work. Still some chores to get done.

@pawel-twardziak
Copy link
Contributor Author

pawel-twardziak commented Oct 13, 2024

@NathanWalker I will be working on this for the next week - so should be done soon :)

@NathanWalker
Copy link
Contributor

NathanWalker commented Oct 15, 2024

ok excellent @pawel-twardziak just ping when ready and we'll merge this into the other pending PR which has ton of executor standardization improvements before releasing v20.

@pawel-twardziak
Copy link
Contributor Author

pawel-twardziak commented Oct 15, 2024

Hi @NathanWalker I see there has beed done a huge job out there #57
Do you want to merge my work DIRECTLY into that one or passing through the main branch?

Btw I have got sick a bit. Getting better and better

@NathanWalker
Copy link
Contributor

If you want to try the merge, you could try merging his into yours or vice versa - ideally we want to merge both your work here and that one.

@pawel-twardziak
Copy link
Contributor Author

I don't like merging other people's work with anything but the main :) Simply out of respect for someone else's work.
I recommend merging one of the work first - mine is simpler (just one responsibility) so this could be the first imho.
That #57 PR takes many resposibilities which is not the best approach 😆 so we could continue on that one next to eventually get both of them done :)

@pawel-twardziak
Copy link
Contributor Author

And I am activly migrating https://github.com/nxext/nx-extensions (it is done, now fixing period) to NX20 too, so I work on two fronts 😆

@NathanWalker
Copy link
Contributor

Agreed, just make this ready for review when ready and we'll merge this first then.

@pawel-twardziak
Copy link
Contributor Author

Thank you @NathanWalker 👍 I am sluggish as being sick but I am speeding up! 😺
I assume I should get mine done by Saturday (including).

@pawel-twardziak
Copy link
Contributor Author

Hi @NathanWalker I will be continuing on it this Sunday (unfortunately tomorrow I cannot). Expect my PR ready by 4pm. I was delayed due to illness.

@pawel-twardziak pawel-twardziak marked this pull request as ready for review October 20, 2024 12:13
@pawel-twardziak
Copy link
Contributor Author

pawel-twardziak commented Oct 20, 2024

@NathanWalker ready to CR. In general, for some reason, fixing package dep version while lint --fix does not work. I dunno why. Need to investigate it a bit more. For now, I did it manually.

UPDATE: I've just activated fixing package dep versions while lint --fix

@pawel-twardziak
Copy link
Contributor Author

@NathanWalker are you there? :)

@NathanWalker
Copy link
Contributor

We’ll check that out and get this merged today

@NathanWalker NathanWalker merged commit 0327592 into NativeScript:main Oct 22, 2024
@pawel-twardziak pawel-twardziak deleted the nx-20-support branch October 22, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants