fix: stop using filter in module generation schematic #248
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's say that you execute the command:
Before this PR:
migrate-module
schematic uses themodule
schematic to generate a NgModule withname='about'
;module
schematic filters out the files that end withabout.module.ts
- this is done because otherwise the we'll get a merge conflict;module
schematic uses the external@schematics/angular module
schematic to generateabout.module.ts
;migrate-module
schematic renamesabout.module.ts
toabout.module.tns.ts
.Unfortunately, the
filter
function visits all files innode_modules
andplatforms
and slows down the execution of themodule
schematic significantly.With this PR:
migrate-module
schematic generates a NgModule file from a template instead of relying on themodule
schematic.module
schematic doesn't usefilter
anymore, which speeds up the execution of the command.fixes #185, #203