Skip to content

Fix issues when used in Angular reactive forms #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 1, 2019

Conversation

VladimirAmiorkov
Copy link
Contributor

PR Checklist

What is the current behavior?

Using PickerField inside an Angular reactive forms group with initial value causes inconsistent behavior of the selectedValue and text property.

What is the new behavior?

Using PickerField inside an Angular reactive forms group with initial value the selectedValue and text property are correctly set.

@VladimirAmiorkov VladimirAmiorkov self-assigned this Mar 1, 2019
@VladimirAmiorkov VladimirAmiorkov requested a review from a team March 1, 2019 12:46
@cla-bot cla-bot bot added the cla: yes label Mar 1, 2019
@ghost ghost added new PR and removed cla: yes labels Mar 1, 2019
@cla-bot cla-bot bot added the cla: yes label Mar 1, 2019
@ghost ghost assigned zbranzov Mar 1, 2019
@VladimirAmiorkov VladimirAmiorkov merged commit e93e577 into master Mar 1, 2019
@VladimirAmiorkov VladimirAmiorkov deleted the amiorkov/reactive-forms-value-fix branch March 1, 2019 16:20
@ghost ghost removed the new PR label Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants