This repository was archived by the owner on Nov 8, 2023. It is now read-only.
Package typings #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hdeshev
commented
Jan 25, 2016
hdeshev
commented
- include nativescript-geolocation.d.ts in the npm module
- change ios/android types to any to speed up user compiles.
Avoiding the need for the huge platform d.ts files which significantly speeds up compilation.
- Move typings to "location" and "location-monitor" modules. - Implement Location in nativescript-geolocation-common - Implement LocationManager in both android and ios modules - Shared code in common (getCurrentLocation) uses a lazy import to get the correct implementation. - Added an index.d.ts that reexports everything at the top level.
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.