chore: revert the tilde resolution as it was removed by mistake #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosen-vladimirov
approved these changes
Feb 7, 2019
vchimev
reviewed
Feb 7, 2019
| @@ -80,6 +81,19 @@ function addTsLib(existingConfig, libName) { | |||
| } | |||
| } | |||
|
|
|||
| function addTnsCoreModulesPathMappings(existingConfig, displayableTsconfigPath, projectDir) { | |||
There was a problem hiding this comment.
Could change the function's name as it no longer maps tns-core-modules short imports, but only tilde. ;)
dtopuzov
added a commit
to NativeScript/nativescript-tooling-qa
that referenced
this pull request
Feb 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
The tilde resolution stopped working as we removed it along with the short imports deprecation.
What is the new behavior?
Only the short imports handling is removed from the paths and the tilde support is back again.