Refactor project and platform services #7
Conversation
lib/node-package-manager.ts
Outdated
There was a problem hiding this comment.
action shouldn't be any. Rather, it should be, let's say, action: (...args: any[]) => void.
There was a problem hiding this comment.
you can simplify the signature for args by using open-ended arguments: ...args: any[]
There was a problem hiding this comment.
Agree :) It looks better
There was a problem hiding this comment.
This is odd. Isn't options.release a boolean value? Why would it have the value --release ?
lib/declarations.ts
Outdated
There was a problem hiding this comment.
This method can be made private in the implementation. The installSafe method can be renamed to just install, then.
|
👍 |
lib/node-package-manager.ts
Outdated
There was a problem hiding this comment.
You can move this after the other public method in this class.
|
@ligaz I did the folowings:
|
lib/constants.ts
Outdated
There was a problem hiding this comment.
We are already using the FOLDER_NAME convention so it looks better to name this PROJECT_FRAMEWORK_FOLDER_NAME.
|
Yes, it looks much better after this refactoring. Good job 😉 |
|
👍 well done. |
Refactor project and platform services
We need this refactoring in order to reuse code for
iOSProjectService