Skip to content

fix(unit-testing): add correct files pattern in karma.conf.js when the project has nsconfig file #4086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2018
Merged

fix(unit-testing): add correct files pattern in karma.conf.js when the project has nsconfig file #4086

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/commands/test-init.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,9 @@ class TestInitCommand implements ICommand {
const frameworks = [frameworkToInstall].concat(this.karmaConfigAdditionalFrameworks[frameworkToInstall] || [])
.map(fw => `'${fw}'`)
.join(', ');
const testFiles = `'${relativeTestsDir}/**/*.js'`;
const karmaConfTemplate = this.$resources.readText('test/karma.conf.js');
const karmaConf = _.template(karmaConfTemplate)({ frameworks });
const karmaConf = _.template(karmaConfTemplate)({ frameworks, testFiles });

this.$fs.writeFile(path.join(projectDir, 'karma.conf.js'), karmaConf);

Expand Down
2 changes: 1 addition & 1 deletion resources/test/karma.conf.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ module.exports = function(config) {

// list of files / patterns to load in the browser
files: [
'app/**/*.js',
${ testFiles }
],


Expand Down