Skip to content

chore: add animations as peer dependency #1121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

vchimev
Copy link
Contributor

@vchimev vchimev commented Dec 12, 2017

The update-app-ng-deps script does not update animations because it is missing as a peer dependency.

@ghost ghost assigned vchimev Dec 12, 2017
@ghost ghost added the in progress label Dec 12, 2017
@vchimev vchimev requested a review from sis0k0 December 12, 2017 17:25
@sis0k0
Copy link
Contributor

sis0k0 commented Dec 12, 2017

"angular/animations" is not a peerDependency for a reason. You can have a project that's not using it and nativescript-angular shouldn't print warnings about that.

@vchimev vchimev closed this Dec 18, 2017
@vchimev vchimev deleted the vchimev-peers branch December 18, 2017 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants