Skip to content

feat: allow embedding into Swift host projects #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jul 1, 2024
Merged

feat: allow embedding into Swift host projects #231

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
3ca9cb1
Add runScript API and default metadata
tdermendjiev Sep 25, 2023
deabadf
Add files for spm package and add methods for shutdown/restart engine
tdermendjiev Oct 5, 2023
41d55f5
Merge branch 'NativeScript:main' into teodor/embedding
tdermendjiev Oct 19, 2023
772c613
Remove embedding directory
tdermendjiev Oct 20, 2023
b1350e7
Merge branch 'main' into teodor/embedding
tdermendjiev Apr 4, 2024
1b18e9c
Clear tasks and detach inspector client on runtime shutdown
tdermendjiev Apr 4, 2024
f44aa18
Merge branch 'main' into teodor/embedding
tdermendjiev Apr 11, 2024
b93e99c
Merge remote-tracking branch 'origin/embed' into pr/231
NathanWalker May 28, 2024
0a15501
Remove debug metadata path from build settings
tdermendjiev May 31, 2024
6055045
Merge branch 'main' into teodor/embedding
edusperoni Jun 26, 2024
ef27957
chore: revert unrelated changes
edusperoni Jul 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove debug metadata path from build settings
  • Loading branch information
@tdermendjiev
tdermendjiev committed May 31, 2024
commit 0a15501fdeab9967a6850f77855bc8c4541b9b89
2 changes: 0 additions & 2 deletions v8ios.xcodeproj/project.pbxproj
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are all these changes necessary in this pbxproj file @tdermendjiev ?

Original file line number Diff line number Diff line change
Expand Up @@ -2561,7 +2561,6 @@
"$(inherited)",
"@executable_path/Frameworks",
);
NS_DEBUG_METADATA_PATH = "/Users/teodordermendzhiev/workspace/ns-v8ios-runtime/yaml";
OTHER_LDFLAGS = (
"-Wl,-search_paths_first",
"-ObjC",
Expand Down Expand Up @@ -2600,7 +2599,6 @@
"$(inherited)",
"@executable_path/Frameworks",
);
NS_DEBUG_METADATA_PATH = "/Users/teodordermendzhiev/workspace/ns-v8ios-runtime/yaml";
OTHER_LDFLAGS = (
"-Wl,-search_paths_first",
"-ObjC",
Expand Down