Skip to content
This repository was archived by the owner on Nov 17, 2022. It is now read-only.

fix(docs): remove cask from brew commands #1946

Merged
merged 2 commits into from
Feb 22, 2021

Conversation

Fadarrizz
Copy link
Contributor

It is no longer required to install cask packages with brew cask, since it has been integrated within brew itself in version 2.5.

See the release notes for more information
https://brew.sh/2020/09/08/homebrew-2.5.0/

PR Checklist

What is the current state of the documentation article?

Many brew cask commands have been integrated with brew. The commands that use cask in the documentation don't work anymore.

What is the new state of the documentation article?

The two commands that make use of cask have been updated, so that they work again.

It is no longer required to install cask packages with `brew cask`, since it has been integrated within brew itself in version 2.5.

See the release notes for more information
https://brew.sh/2020/09/08/homebrew-2.5.0/
@cla-bot
Copy link

cla-bot bot commented Feb 21, 2021

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @Fadarrizz.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

@rigor789
Copy link
Member

I believe it has been deprecated, and replaced by the --cask flag, so it should be

brew install --cask adoptopenjdk8

instead? (https://formulae.brew.sh/cask/adoptopenjdk#default)

image

@Fadarrizz
Copy link
Contributor Author

I believe it has been deprecated, and replaced by the --cask flag, so it should be

brew install --cask adoptopenjdk8

instead? (https://formulae.brew.sh/cask/adoptopenjdk#default)

image

Interesting, I ran both commands without the --cask flag and that seems to work as well.

But I believe it's better to follow the provided installation guidelines from brew itself, so I shall add the flag.

@Fadarrizz
Copy link
Contributor Author

@cla-bot check

@cla-bot cla-bot bot added the cla: yes label Feb 22, 2021
@cla-bot
Copy link

cla-bot bot commented Feb 22, 2021

The cla-bot has been summoned, and re-checked this pull request!

@Fadarrizz Fadarrizz changed the title Remove cask from brew commands fix(docs): remove cask from brew commands Feb 22, 2021
@rigor789 rigor789 merged commit e4bfdf5 into NativeScript:master Feb 22, 2021
@rigor789
Copy link
Member

Thanks @Fadarrizz!

@Fadarrizz Fadarrizz deleted the patch-1 branch February 22, 2021 14:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants