Skip to content
This repository was archived by the owner on Nov 17, 2022. It is now read-only.

fix: Fixed typo in upgrade-instructions.md #1917

Merged
merged 1 commit into from
Feb 15, 2021
Merged

fix: Fixed typo in upgrade-instructions.md #1917

merged 1 commit into from
Feb 15, 2021

Conversation

adrian-niculescu
Copy link
Contributor

Fixed typo

PR Checklist

@cla-bot
Copy link

cla-bot bot commented Sep 25, 2020

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @adrian-niculescu.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

@adrian-niculescu
Copy link
Contributor Author

@cla-bot check

@cla-bot cla-bot bot added the cla: yes label Sep 25, 2020
@cla-bot
Copy link

cla-bot bot commented Sep 25, 2020

The cla-bot has been summoned, and re-checked this pull request!

@adrian-niculescu adrian-niculescu changed the title Update upgrade-instructions.md fix: Fixed typo in upgrade-instructions.md Sep 25, 2020
Copy link
Contributor

@avats-dev avats-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hii @adrian-niculescu , this looks good. Although as your PR has just one commit, you need it to be a semantic commit to pass the checks. So I think there are two ways for avoiding this:

  • either someone merges this with the failing checks, depends on the reviewers and maintainers.
  • or you might add more commits (i.e. resolve more minor issues along with this PR). Just commit your changes and the PR will get updated by itself.

Please mention if there is any issue relevant to this PR to avoid duplicate works and save time. Thanks for contributing. 🎉

@rigor789 rigor789 merged commit ee857b6 into NativeScript:master Feb 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants