Skip to content

⚡ Upgrade tailwind version to 4 #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 4, 2025
Merged

Conversation

HassanZahirnia
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@steven-fox steven-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks very good to me, Hassan! Thank you!

Only minor things I saw:

  1. Noticed the vite config was not changed to include the @tailwindcss/vite plugin, but you've informed that is not necessary.
  2. We should add styling to the base css to make buttons have a pointer cursor again.
@layer base {
  button:not(:disabled),
  [role="button"]:not(:disabled) {
    cursor: pointer;
  }
}

@steven-fox steven-fox merged commit e2766bd into main Jun 4, 2025
2 checks passed
@steven-fox steven-fox deleted the upgrade-tailwind-version-to-4 branch June 4, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants