iOS build now respects cleanup_exclude_files config#17
Open
tbtmuse wants to merge 2 commits intoNativePHP:mainfrom
Open
iOS build now respects cleanup_exclude_files config#17tbtmuse wants to merge 2 commits intoNativePHP:mainfrom
tbtmuse wants to merge 2 commits intoNativePHP:mainfrom
Conversation
BuildIosAppCommand::copyLaravelAppIntoIosApp() had a bespoke
RecursiveIteratorIterator with hardcoded exclusions that ignored
the user-configurable nativephp.cleanup_exclude_files setting.
Replace with the shared PlatformFileOperations::platformOptimizedCopy()
trait already used by InstallCommand, PackageCommand, and RunCommand.
This also merges config('nativephp.cleanup_exclude_files') into the
exclusion list, matching the pattern in PreparesBuild for Android.
Member
|
Duplicates #2 |
Author
|
@simonhamp I would argue that this PR actually makes use of preexisting code rather than intruducing new code, ultimately unifying the code that is used for this function on both platforms and making it easier to reason about. It is a simplification. Would you reconsider from that perspective? |
Member
|
I do think this is the better implementation... but it needs the test from #2 to prove that it's working |
Author
|
Sure thing, I will add the test. |
tbtmuse
force-pushed
the
fix/ios-build-platform-file-operations
branch
2 times, most recently
from
a3a749a to
06fb769
Compare
- Add IosBuildCopyTest
tbtmuse
force-pushed
the
fix/ios-build-platform-file-operations
branch
from
06fb769 to
677a22b
Compare
Author
|
@simonhamp tests added, happy to make further adjustments if necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BuildIosAppCommand::copyLaravelAppIntoIosApp() had hardcoded exclusions that ignored the user config in nativephp.cleanup_exclude_files.
Replace with the shared PlatformFileOperations::platformOptimizedCopy() already in use on the android side.