Fixed error "method_exists(): Argument #1 ($object_or_class) must be of type object|string, array given" when using Livewire and AdminLTE. #524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… must be of type object|string, array given' when using Darryldecode\Cart\Cart.
|
Hi @JA-Developer. Thanks so much for your PR 🙏 Perfect, I think this check makes sense here. We only want to handle events that are broadcasted on the NativePHP channel here, and return as early as possible if it is not. Could you perhaps update this to an return clause with is_object? We think this is slightly more legible by anvoiding any unnecessary casting. |
…ispatched by NativePHP.
|
Yes. I made the changes you asked for, |
PeteBishwhip
approved these changes
Mar 24, 2025
| if(! is_object($event)) { | ||
| return; | ||
| } | ||
|
|
||
| if (! method_exists($event, 'broadcastOn')) { |
There was a problem hiding this comment.
The following would have sufficed as conditionals are evaluated in order and reduced the need for an additional return clause however, the above works too. Thanks!
Suggested change
| if (! method_exists($event, 'broadcastOn')) { | |
| if (!is_object($event) || ! method_exists($event, 'broadcastOn')) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made the changes mentioned in the issue #517. That the exception "method_exists(): Argument #1 ($object_or_class) must be of type object|string, array given" from being thrown.