Skip to content

Fix accessing window properties #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 14, 2024
Merged

Fix accessing window properties #410

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e79b106
Add type hint
simonhamp Nov 14, 2024
3828de4
Add magic getter
simonhamp Nov 14, 2024
bcad9fa
Cleanup
simonhamp Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/Events/EventWatcher.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ public function __construct(protected Client $client) {}
public function register(): void
{
Event::listen('*', function (string $eventName, array $data) {

$event = $data[0] ?? (object) null;

if (! method_exists($event, 'broadcastOn')) {
Expand Down
7 changes: 6 additions & 1 deletion src/Windows/Window.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ class Window

protected bool $kiosk = false;

protected $rememberState = false;
protected bool $rememberState = false;

protected bool $alwaysOnTop = false;

Expand Down Expand Up @@ -362,4 +362,9 @@ public function fromRuntimeWindow(object $window): static

return $this;
}

public function __get($var)
{
return $this->$var ?? null;
}
}
Loading