fix: Please provide a valid cache path. #205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The previous method for providing these directories was by force adding them in the build. But then they would only be created on first run. What you do now is a better solution. Should we remove these lines from the build command? I don’t think we need them both (untested) |
|
We should keep them both for now. I will check later if it's still necessary |
simonhamp
approved these changes
Apr 5, 2025
PeteBishwhip
approved these changes
Apr 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the added environment variable in this commit, we definitely need to create those directories ourselves.
Why did it work before?
Because previously, the app was sometimes writing to itself.
With bundling, we need every write operation to be outside the app.
This is why we introduced the usage of
LARAVEL_STORAGE_PATH.