Node Minimum Version Bump to Support Electron #202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SRWieZ
approved these changes
Apr 4, 2025
simonhamp
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to the Node.js version used in various workflows and configuration files. The most important changes are:
Workflow Updates:
.github/workflows/build-plugin.yml: Updated Node.js version from 20.x to 22.x..github/workflows/run-plugin-tests.yml: Updated Node.js version from 20.x to 22.x..github/workflows/run-tests.yml: Updated Node.js version from 20.x to 22.x.Configuration Files:
resources/js/package-lock.json: Updated Node.js engine requirement from >=18.0.0 to >=22.0.0.resources/js/package.json: Updated Node.js engine requirement from >=18.0.0 to >=22.0.0.Supporting Documentation
https://www.electronjs.org/blog/ecosystem-node-22/
NOTE: This will also require an update to our documentation to make it clear that Node 22+ is required.