Skip to content

fix: caching config while in dev will make laravel think it's in elec… #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 3, 2025
Merged

fix: caching config while in dev will make laravel think it's in elec… #201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d593359
fix: caching config while in dev will make laravel think it's in elec…
SRWieZ Apr 3, 2025
22e5400
Build plugin
SRWieZ Apr 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion resources/js/electron-plugin/dist/server/php.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ function shouldMigrateDatabase(store) {
&& process.env.NODE_ENV !== 'development';
}
function shouldOptimize(store) {
return true;
return process.env.NODE_ENV !== 'development';
}
function getPhpPort() {
return __awaiter(this, void 0, void 0, function* () {
Expand Down
3 changes: 2 additions & 1 deletion resources/js/electron-plugin/src/server/php.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@ function shouldOptimize(store) {
* the cached config is not picked up on subsequent launches,
* so we'll just rebuilt it every time for now
*/
return true;

return process.env.NODE_ENV !== 'development';
// return runningSecureBuild();
// return runningSecureBuild() && store.get('optimized_version') !== app.getVersion();
}
Expand Down