fix: zephpyr.com bundle on Windows #196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SRWieZ
changed the title
simonhamp
approved these changes
Mar 31, 2025
PeteBishwhip
approved these changes
Apr 1, 2025
There was a problem hiding this comment.
Looks good to me. I learnt something new today as I didn't know the ZIP extension would require / over \. I think if you have a known error path for when this affects a ZIP, a test would be good to ensure this doesn't revert back to \ in the future. Happy for merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ZIP extension in PHP expects forward slashes (/) as directory separators inside archives, regardless of the operating system.