Skip to content

ci: Update building plugin => Node.js v20 + create pull request #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 31, 2025

Conversation

SRWieZ
Copy link
Member

@SRWieZ SRWieZ commented Mar 31, 2025

This pull request updates the GitHub Actions workflow for building the plugin.

  • Updated the Node.js version from 18.x to 20.x.
  • Updated stefanzweifel/git-auto-commit-action to run on pull requests, allowing for faster testing of proposed changes.
  • Added peter-evans/create-pull-request on the main branch to ensure it builds even after squashing and merging.

@PeteBishwhip
Copy link
Member

Just wondering, but is it worth having the plugin build no longer target pull_request at all and only on changes to main? We avoid noisy commits and we can merge in that single PR prior to release with all the changes merged between X and Y?

@SRWieZ
Copy link
Member Author

SRWieZ commented Mar 31, 2025

I just updated my description. I propose the following:

  • Auto building on the pull request to test the changes, as I prefer checking the code and testing it in my app when possible.
  • Auto building on the main branch, because after merging, the plugin also needs to be rebuilt.

@simonhamp simonhamp merged commit e9db0e9 into main Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants