Skip chmod on Windows to avoid unnecessary permission changes #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonhamp
reviewed
Mar 24, 2025
SRWieZ
approved these changes
Mar 26, 2025
simonhamp
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request prevents chmod from running on Windows, as it is not required and can be skipped safely.
Changes made:
Added a condition to check the operating system (PHP_OS).
chmod($target, $perms); now only executes on non-Windows systems.
Reason for the change:
Since Windows does not support Unix-style file permissions, calling chmod is unnecessary and has no effect. This update ensures compatibility and avoids redundant function calls on Windows environments.
Testing & Impact:
This change does not affect Linux/macOS functionality.
It improves Windows compatibility by preventing unnecessary operations.